[TYPO3-dam-devel] RFC: Bugfix: 5527: Go to editing of DAM record from the content element (image)

[Benjamin Mack]

Hey Peter,

Peter Kuehn [wmdb] wrote:
> -1 and a bit confused:
> 
> lines 53/54 of class.tx_dam_cm_file.php reads:
well, pretty simple (AFAIK):

>    // Returns directly, because the clicked item was not a file
>    if ($backRef->cmLevel==0 AND $uid!='') return $menuItems;
well, pretty simple: you're on class.tx_dam_cm_file.php, so basically 
there shouldn't be a $uid set on the main level.

The alt_clickmenu.php usually takes care of it.... if $uid is filled, 
then alt_clickmenu.php automatically chooses class.tx_dam_cm_record.php, 
so IMHO this check is completely redundant.

Plus: This patch does not change this line, so I don't see this as a 
reason for a -1, right?

-- 
greetings,
benni.
-SDG-