[TYPO3-dam-devel] RFC 7859: DAM adds column ce_flexform on wrong condition

[Michiel Roos]

+1 by reading the code a week ago, and now this patch

On May 2, 2008, at 4:41 PM, Benjamin Mack wrote:

> Hey all,
>
> this is a SVN patch request.
>
> Severity: no-brainer / minor
>
> Branches: 1.1 (trunk) only
>
> BT reference: http://bugs.typo3.org/view.php?id=7859
>
> Problem:
> In ext_tables.php the additional column "ce_flexform" for tt_content  
> is added if "$TCA['tx_dam']['columns']['ce_flexform']" is not set  
> yet. Well, since the ce_flexform column is added to tt_content, this  
> check always returns false.
>
> Solution:
> The check needs to be
> if (!isset($TCA['tt_content']['columns']['ce_flexform'])) {
> to check if the column is already present in tt_content, not in  
> tx_dam.
>
> Notes:
> If no one objects, I'd like to commit this in 24hs.
>
> greetings,
> benni.
> -SDG-
> Index: ext_tables.php
> ===================================================================
> --- ext_tables.php	(revision 9058)
> +++ ext_tables.php	(working copy)
> @@ -46,7 +46,7 @@
> 	'tx_dam_images' => txdam_getMediaTCA('image_field', 'tx_dam_images'),
> 	'tx_dam_files' => txdam_getMediaTCA('media_field', 'tx_dam_files'),
> );
> -if (!isset($TCA['tx_dam']['columns']['ce_flexform'])) {
> +if (!isset($TCA['tt_content']['columns']['ce_flexform'])) {
> 	$tempColumns['ce_flexform'] = array(
> 		'l10n_display' => 'hideDiff',
> 		'exclude' => 1,
> _______________________________________________
> Before posting to this list, please have a look to the posting rules
> on the following websites:
>
> http://typo3.org/teams/core/core-mailinglist-rules/
> http://typo3.org/development/bug-fixing/diff-and-patch/
> _______________________________________________
> TYPO3-team-dam mailing list
> TYPO3-team-dam at lists.netfielders.de
> http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-team-dam


Met vriendelijke groet,

Michiel Roos

Netcreators BV :: creation and innovation
www.netcreators.com

Interesse in werken bij Netcreators?
http://www.netcreators.com/bedrijf/vacatures/