[TYPO3-dam-devel] RFC #6766: getReferencedFiles $whereClauses as string

Benjamin Mack benni at typo3.org
Fri May 2 10:43:49 CEST 2008


Hey guys,

this is a SVN patch request for the DAM project.

Severity: no-brainer

Branches: Both trunk and dam_1.0 branch

Problem:
In two cases in "lib/class.tx_dam_db.php" the use preg_replace is just 
simply wrong. It should remove the "AND..." in front of a whereClause. 
Then the preg_replace needs to look like preg_replace('/AND /', '', 
$whereClauses);.
unfortunately, the second parameter is left out.

Solution:
Add the second (empty '') parameter.

Notes:
As this is just a clear wrong use of a function call, I'd like to commit 
this in 24h if no one objects.

-- 
greetings,
benni.
-SDG-
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20080502_6766_wrong_use_of_pregreplace.patch
Type: text/x-diff
Size: 1369 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-dam/attachments/20080502/5aede8f0/attachment.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20080502_6766_wrong_use_of_pregreplace_1.0_branch.patch
Type: text/x-diff
Size: 748 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-dam/attachments/20080502/5aede8f0/attachment-0001.patch 


More information about the TYPO3-team-dam mailing list