[TYPO3-dam-devel] RFC: #8598: Media > File: Icons are hidden by Fieldsize in IE 7.0

[Michiel Roos [netcreators]]

+1

On Jun 14, 2008, at 8:56 PM, Dan Osipov wrote:

> I agree, I thought to provide a quick fix for the problem. Attached  
> is the more complete solution, with accordance to the comments.
>
> Dan Osipov
> Calkins Media
> http://phillyburbs.com/
>
> Benjamin Mack wrote:
>> Hey Dan,
>> nice! However I have one remark:
>> The code looks like this currently:
>> =========
>> $content = '
>>    <!-- CONTROL PANEL: tx_dam:'.$item['uid'].' -->
>> -    <div class="typo3-DBctrl">'.implode('', $actions).'</div>';
>> +    '.implode('', $actions).'';
>> }
>> =========
>> However, I suggest make it shorter, by just having
>> $content = implode('', $actions);
>> as we don't need the comment, also the line before "compile items  
>> into a DIV element, can go IMHO.
>> Can you make these small non-functional changes? Apart from that,  
>> it looks good. I will have a look at it again, once the other patch  
>> (styling) is improved as well again.
> Index: class.tx_dam_listfiles.php
> ===================================================================
> --- class.tx_dam_listfiles.php	(revision 9306)
> +++ class.tx_dam_listfiles.php	(working copy)
> @@ -393,11 +393,7 @@
>
> 			$actionCall[$item['__type']]->setRequest('control', $item);
> 			$actions = $actionCall[$item['__type']]- 
> >renderActionsHorizontal(true);
> -
> -				// Compile items into a DIV-element:
> -			$content = '
> -											<!-- CONTROL PANEL: tx_dam:'.$item['uid'].' -->
> -											<div class="typo3-DBctrl">'.implode('', $actions).'</ 
> div>';
> +			$content = implode('&nbsp;', $actions);
> 		}
>
> 		return $content;
> Index: class.tx_dam_listrecords.php
> ===================================================================
> --- class.tx_dam_listrecords.php	(revision 9306)
> +++ class.tx_dam_listrecords.php	(working copy)
> @@ -531,11 +531,7 @@
>
> 			$actionCall->setRequest('control', $item);
> 			$actions = $actionCall->renderActionsHorizontal(true);
> -
> -				// Compile items into a DIV-element:
> -			$content = '
> -											<!-- CONTROL PANEL: tx_dam:'.$item['uid'].' -->
> -											<div class="typo3-DBctrl">'.implode('', $actions).'</ 
> div>';
> +			$content = implode('&nbsp;', $actions);
> 		}
>
> 		return $content;
> _______________________________________________
> Before posting to this list, please have a look to the posting rules
> on the following websites:
>
> http://typo3.org/teams/core/core-mailinglist-rules/
> http://typo3.org/development/bug-fixing/diff-and-patch/
> _______________________________________________
> TYPO3-team-dam mailing list
> TYPO3-team-dam at lists.netfielders.de
> http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-team-dam


Met vriendelijke groet,

Michiel Roos

Netcreators BV :: creation and innovation
www.netcreators.com

Interesse in werken bij Netcreators?
http://www.netcreators.com/bedrijf/vacatures/