[TYPO3-dam-devel] RFC: Bugfix: 8236: double media folder after update

[Peter Kuehn [wmdb]]

the changes in the patch roll back(!) a change from doktype 254 to 
doktype 2 that apparently was introduced somewhere on the way from 
1.0.100 to 1.0.13.
using "advanced" instead of "sysfolder" must have had a reason. anybody 
who knows it? im a little afraid, that we will have a new prob somewhere 
  else that was solved by using doktype 2.

anyways: michiel is right "there is no history And since 2 is obsoleted 
by 4.2 we have little choice".

so: +1 for the patch and some thoughts on why it was changed someday.

grtz
pekue


Michiel Roos schrieb:
> This is a svn patch request.
> 
> Type: bugfix
> 
> Bugracker reference: http://bugs.typo3.org/view.php?id=8236
> 
> Description:
> After the update to Typo3 4.2.0 a double media folder exists.
> The second one (new one) can not be deleted.... a new one is generated 
> autmaticly (id +1).
> The old folder contains the categories, the new one does not.
> 
> Cause:
> In TYPO3 4.2 the page type 2 (Advanced) was removed. A function checks 
> for existence of the media folder as follows:
> if ($damFolders = 
> $GLOBALS['TYPO3_DB']->exec_SELECTgetRows('uid,pid,title', 'pages', 
> 'doktype=2 and module='.$GLOBALS['TYPO3_DB']->fullQuoteStr('dam', 
> 'pages').' AND deleted=0', '', '', '', 'uid')) {
> 
> In 4.2 this check always fails.
> 
> Solution:
> Change the above line into
> if ($damFolders = 
> $GLOBALS['TYPO3_DB']->exec_SELECTgetRows('uid,pid,title,doktype', 
> 'pages', 'module='.$GLOBALS['TYPO3_DB']->fullQuoteStr('dam', 'pages').' 
> AND deleted=0', '', '', '', 'uid')) {
> 
> And in the create functions the line: 
> 
>     $fields_values['doktype'] = 254;
> 
> should be changed to:
> 
>     $fields_values['doktype'] = 2;
> 
> Please find a patch attached
> 
> Met vriendelijke groet,
> 
> Michiel Roos
> 
> Netcreators BV :: creation and innovation
> www.netcreators.com <http://www.netcreators.com> 
> 
> Interesse in werken bij Netcreators?
> http://www.netcreators.com/bedrijf/vacatures/ 
> 
> 
> ------------------------------------------------------------------------
> 
>