[TYPO3-dam-devel] RFC Bugfix: 5681: Link Popup javascript error when changing DAM directory in File selection

[Andreas Balzer]

+1

On Nov 14, 2007 4:09 PM, Peter Kuehn [wmdb] <peter.kuehn at wmdb.de> wrote:

> This is a svn patch request.
>
> Type: bugfix
>
> Steps to reproduce:
> - use IE
> - create a content element type text
> - insert text in the RTE, select it and click "Insert Web Link"
> - click the file-tab
> - select a folder in the tree
> => js error "syntaxerror on line 112"
> - hit ok and try to select a file
> => js error "Object expected on line 798"
>
>
> Observed behaviour:
> unable to select a file from EB to link it in RTE
>
> Reason:
> tx_dam_selectionFolder->eb_wrapTitle() doesnt include the needed GET-Var
> "editorNo" in the generated call to jumpToUrl()
>
>
> Branches:
> Head
>
> Bugtracker reference: http://bugs.typo3.org/view.php?id=5681
>
> pls confirm - this was the DAMned hardest to cook patch i ever had to ...
> ;)
>
> Index: class.tx_dam_selectionFolder.php
> ===================================================================
> --- class.tx_dam_selectionFolder.php    (revision 7113)
> +++ class.tx_dam_selectionFolder.php    (working copy)
> @@ -547,7 +547,7 @@
>         * @return      string
>         */
>        function eb_wrapTitle($title,$row)      {
> -               $aOnClick = 'return
> jumpToUrl(\''.$this->thisScript.'?act='.$GLOBALS['SOBE']->act.'&mode='.$GLOBALS['SOBE']->mode.'&bparams='.$GLOBALS['SOBE']->bparams.$this->getJumpToParam($row).'\');';
> +               $aOnClick = 'return
> jumpToUrl(\''.$this->thisScript.'?act='.$GLOBALS['SOBE']->act.'&mode='.$GLOBALS['SOBE']->mode.'&bparams='.$GLOBALS['SOBE']->bparams.($GLOBALS['SOBE']->browser->editorNo?'&editorNo='.$GLOBALS['SOBE']->browser->editorNo:'').$this->getJumpToParam($row).'\');';
>                return '<a href="#"
> onclick="'.htmlspecialchars($aOnClick).'">'.$title.'</a>';
>        }
>
>
> _______________________________________________
> TYPO3-team-dam mailing list
> TYPO3-team-dam at lists.netfielders.de
> http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-team-dam
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.netfielders.de/pipermail/typo3-team-dam/attachments/20071114/57c37c92/attachment.htm