[TYPO3-dam-devel] RFC: Bugfix: 6697: two minus signs in filename

[Peter Kühn]

Andreas Balzer schrieb:
 > +1 to the following three:
 > http://bugs.typo3.org/view.php?id=5681
 > http://bugs.typo3.org/view.php?id=6700
 > http://bugs.typo3.org/view.php?id=6697


Peter Kühn schrieb:
> hi georg,
> 
> your right - completed patch attached.
> 
> pls ack
> pekue
> 
> georg kuehnberger schrieb:
>> Peter, basically +1 (that is the patch works),
>> however the mentioned changes have to be applied to:
>>
>> dam/lib/class.tx_dam_listrecords.php
>> line 535 onwards - as you mentioned,
>>
>> AND also to:
>>
>> dam/modfunc_list_thumbs/class.tx_dam_list_thumbs.php
>> line 372 onwards
>>
>> dam/lib/class.tx_dam_listfiles.php
>> line 397 onwards
>>
>> regards georg
>>
>>
>>
>> Peter Kuehn [wmdb] wrote:
>>> This is a svn patch request.
>>>
>>> Type: bugfix
>>>
>>> Steps to reproduce:
>>> - upload a file with two dashes like "my--file.ext"
>>> - index
>>> - view list in FF2
>>>
>>> Expected behaviour:
>>> iconbar should be displayed as usual
>>>
>>> Observed behaviour:
>>> missing edit icons
>>>
>>> Reason:
>>>
>>> class.tx_dam_listrecords.php line 537 renders a comment
>>> <!-- CONTROL PANEL: filename.ext -->
>>> at the begin of the iconbar. two dashes inside a comment are not 
>>> standard compliant and lead to parse problems in some browsers (fx. FF2)
>>>
>>> The fix:
>>> id suggest to change the comment to
>>> <!-- CONTROL PANEL: tx_dam:[recordid] -->
>>> see patch att.
>>>
>>> Branches:
>>> Head
>>>
>>> Bugtracker reference: http://bugs.typo3.org/view.php?id=6697
>>>
>>>
>>> ------------------------------------------------------------------------
>>>
>>> _______________________________________________
>>> TYPO3-team-dam mailing list
>>> TYPO3-team-dam at lists.netfielders.de
>>> http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-team-dam
> 
> 
> ------------------------------------------------------------------------
> 
> Index: lib/class.tx_dam_listfiles.php
> ===================================================================
> --- lib/class.tx_dam_listfiles.php	(revision 7677)
> +++ lib/class.tx_dam_listfiles.php	(working copy)
> @@ -396,7 +396,7 @@
>  
>  				// Compile items into a DIV-element:
>  			$content = '
> -											<!-- CONTROL PANEL: '.htmlspecialchars($item['file_name']).' -->
> +											<!-- CONTROL PANEL: tx_dam:'.$item['uid'].' -->
>  											<div class="typo3-DBctrl">'.implode('', $actions).'</div>';
>  		}
>  
> Index: lib/class.tx_dam_listrecords.php
> ===================================================================
> --- lib/class.tx_dam_listrecords.php	(revision 7677)
> +++ lib/class.tx_dam_listrecords.php	(working copy)
> @@ -534,7 +534,7 @@
>  
>  				// Compile items into a DIV-element:
>  			$content = '
> -											<!-- CONTROL PANEL: '.htmlspecialchars($item['file_name']).' -->
> +											<!-- CONTROL PANEL: tx_dam:'.$item['uid'].' -->
>  											<div class="typo3-DBctrl">'.implode('', $actions).'</div>';
>  		}
>  
> @@ -585,4 +585,4 @@
>  if (defined('TYPO3_MODE') && $TYPO3_CONF_VARS[TYPO3_MODE]['XCLASS']['ext/dam/lib/class.tx_dam_listrecords.php']) {
>  	include_once ($TYPO3_CONF_VARS[TYPO3_MODE]['XCLASS']['ext/dam/lib/class.tx_dam_listrecords.php']);
>  }
> -?>
> \ No newline at end of file
> +?>
> Index: modfunc_list_thumbs/class.tx_dam_list_thumbs.php
> ===================================================================
> --- modfunc_list_thumbs/class.tx_dam_list_thumbs.php	(revision 7677)
> +++ modfunc_list_thumbs/class.tx_dam_list_thumbs.php	(working copy)
> @@ -371,7 +371,7 @@
>  
>  				// Compile items into a DIV-element:
>  			$content = '
> -											<!-- CONTROL PANEL: '.htmlspecialchars($item['file_name']).' -->
> +											<!-- CONTROL PANEL: tx_dam:'.$item['uid'].' -->
>  											<div class="typo3-DBctrl">'.implode('', $actions).'</div>';
>  		}
>