[TYPO3-core] Change CGL for inline comments?

Arvid Jakobsson arvid.jakobsson at gmail.com
Mon Sep 24 08:15:12 CEST 2012


I've been working on a script for re-indenting the one-line comments in the
6.0 core, however, I've not had any great success as of yet. May be it is
more fitting that I write a script for un-indenting the comments, that
could be used for backporting to older branches? Personally though, I think
this would be a lot of work for little benefit.

2012/9/24 Xavier Perseguers <xavier at typo3.org>

> Hi,
>
> > We all agreed that we should go that way and change the CGLs
> >
> > Any major downsides to do so?
>
> I got used to it and like it (visually) for many cases but I must agree
> that it annoys me as well for instance for one-line code within a code
> block and I got the habit NOT to indent for type hinting as I don't
> consider them "comments".
>
> Anyway, you get my +1 for this change and we should define whether we
> allow the lack of indent to be backported to older branches. The
> argument of "ease" the backport has no point here as we have to rewrite
> the patch anyway due to namespaces in 6.0.
>
> I'd personally be in favour of keeping the extra indent in older
> branches to try to keep some "consistency" in older branches and as they
> won't be maintained very much long either.
>
> Kind regards
>
> --
> Xavier Perseguers
> Release Manager TYPO3 4.6
>
> TYPO3 .... inspiring people to share!
> Get involved: http://typo3.org
>
> _______________________________________________
> Before posting to this list, please have a look to the posting rules
> on the following websites:
>
> http://typo3.org/teams/core/core-mailinglist-rules/
> http://typo3.org/development/bug-fixing/diff-and-patch/
> _______________________________________________
> TYPO3-team-core mailing list
> TYPO3-team-core at lists.typo3.org
> http://lists.typo3.org/cgi-bin/mailman/listinfo/typo3-team-core
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20120924/a9bade07/attachment.htm>


More information about the TYPO3-team-core mailing list