[TYPO3-core] Using lex-pass to clean up CGL issues

[Arvid Jakobsson]

Some of the changes are in sysexts. I guess there should be one commit
per extension plus one for the Core? So if I understand everything
correctly:

1. Create a topic-branch in each sysext.
2. Commit and push to gerrit inside the sysext
3. Then create a topic-branch for Core, commit all changes that are
not in sysexts and push?


To reproduce the patches, here are some notes:
For the modified version of lex-pass, see: https://github.com/arvidj/lex-pass
And here are instructions for installing:
http://saker-som-skett.tumblr.com/post/30649503612/successful-install-of-lex-pass-facebook-on-mac-os

I'll be glad to write up more detailed how to use and extend lex-pass,
and how to run it on the TYPO3 source code if there is interest.

Regards, Arvid


2012/9/9 Helmut Hummel <helmut.hummel at typo3.org>:
> Hi Arvid,
>
>
> On 09.09.12 09:49, Arvid Jakobsson wrote:
>
>> I've been modifying Facebook's lex-pass[1] to make it work with the
>> TYPO3 source code. After some modifications it seems to be working
>> fine, and I've written a rule for fixing the ("a" . "b) . "c"
>> issue[2], and also one for fixing trailing commas in Arrays.
>
>
> Great.
>
>
>> So now
>> I'm sitting on a patch with 600 modified files. Where do I go from
>> here? I push it to Gerrit?
>
>
> Yes please. If possible, push one for each cleanup (e.g. one for [2] and one
> for trailing commas in arrays).
>
>
>> I should be able to fix other kinds of CGL
>> issues, like "false" ->  "FALSE", and the comment-indentation issue.
>
>
> Perfekt. Looking forward to see the changes in Gerrit.
>
>
>> [1] https://github.com/facebook/lex-pass
>> [2] http://forge.typo3.org/issues/40113
>
>
>
> Kind regards,
> Helmut
>
> --
> Helmut Hummel
> Release Manager TYPO3 6.0
> TYPO3 Core Developer, TYPO3 Security Team Member
>
> TYPO3 .... inspiring people to share!
> Get involved: typo3.org
>
> _______________________________________________
> Before posting to this list, please have a look to the posting rules
> on the following websites:
>
> http://typo3.org/teams/core/core-mailinglist-rules/
> http://typo3.org/development/bug-fixing/diff-and-patch/
> _______________________________________________
> TYPO3-team-core mailing list
> TYPO3-team-core at lists.typo3.org
> http://lists.typo3.org/cgi-bin/mailman/listinfo/typo3-team-core