[TYPO3-core] RFC #17483: GifBuilder - meaningfulTempFilePrefix can cause invalid image urls

[Bjoern Pedersen]

Am 08.02.2011 20:54, schrieb Stefan Galinski:
> Hi,
> 
> This is a SVN patch request.
> 
> Type: Bugfix
> 
> BT reference: http://bugs.typo3.org/view.php?id=17483
> 
> Branches: trunk / 4_5
> 
> Problem:
> Currently there are incorrect image urls if you use the 
> meaningfulTempFilePrefix option and text with invalid url characters.
> 
> Solution:
> Whitelist the allowed characters instead of managing a blacklist. There are 
> not much allowed characters.
> 
> How To Test:
> Use the following TS snippet to reproduce the issue.
> 
> config.meaningfulTempFilePrefix = 100
> 
> page = PAGE
> page.10 = COA
> page.10 {
>   10 = IMAGE
>   10 {
>     file = GIFBUILDER
>     file {
>       XY = 200,30
>       transparentBackground = 1
>       format = png
>       backColor = #000000
>       
>       15 = TEXT
>       15 {
>         text = täst/123$?&%-_.+!*
>         fontColor = #FFFFFF
>         fontSize = 24
>         offset=0,24
>       }
>     }
>   }
> }
> 

Generally +1 by reading, but why not use
class.t3lib_basicfilefunc:cleanFileName ?

Björn