[TYPO3-core] RFC #12230: Bug: Function tslib_cObj::crop() is not fully multibyte safe

[Sebastian Fischer]

On 31.01.2011 16:23, JoH asenau wrote:
>
>> +1 for the check of length with csconvobj.
>>
>> -1 on changing the concatination in a ternary. There is no improvement
>> by putting the hole in one line. Neither does it improve readbility nor
>> any performance.
>
> Actually the ternary is in the current code and the patch replaces it
> with if/else - so I don't see the problem here.
>
> +1 by reading.
>
> Joey
>
Hi Joey and Vladimir,

@Joey you got me. I was wrong with my statement.

@Vladimir sorry i didnt want to offend you. Your code was perfectly fine.

so +1 for the complete patch.

Greetings
Sebastian