[TYPO3-core] RFC #15075: feature: make a pre-check for required php-extensions

Xavier Perseguers typo3 at perseguers.ch
Tue Sep 28 13:07:31 CEST 2010


Hi,

>> Finally found time to review the patch. Here is my v9 which uses already
>> existing method to retrieve supported drivers.
>>
>
> There is a minor bug in the function. Iterating $this->supportedDrivers
> returns "odbc_mssql" which is not a valid PHP module.
> This is why I explicitly defined the PHP module values.
>
> IMO this won't hurt much, since there's no combination with odbc which
> is not covered by native drivers. But maybe we should add a note to the
> function.

No, it won't hurt and I prefer not having a duplicated list of drivers. 
Thanks for the review.

Xavier


More information about the TYPO3-team-core mailing list