[TYPO3-core] RFC #15801: Deprecate t3lib_div::rm_endcomma

Thorsten Kahler thorsten.kahler at dkd.de
Sat Sep 25 15:13:16 CEST 2010


Hi Benni,

schrieb Benjamin Mack am 24.09.10 20:35:
> Hey all,
> 
> this is a SVN patch request.
> 
> BT reference: http://bugs.typo3.org/view.php?id=15801
> 
> Type: cleanup / deprecation
> 
> Branches: trunk
> 
> Description:
> The function "rm_endcomma" in t3ilb_div is rarely used, and in my eyes
> not useful, as it does the same as a quick rtrim($str, ','), which a
> experienced PHP developer should know. Thus, let's deprecate this
> function and remove it with TYPO3 4.7
> 

would you mind fixing some white space stuff and using the default order
for implode() parameters? See attached version 2 of the patch.

In any case: +1 from me by reading

Cheers
Thorsten

-- 

Thorsten Kahler
thorsten.kahler at dkd.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 15801_rm_endcomma_v2.patch
Type: text/x-patch
Size: 1714 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100925/f8eb6401/attachment.bin>


More information about the TYPO3-team-core mailing list