[TYPO3-core] RFC #13750: Bug: Several GIFBUILDER features broken for IM4, IM6 and GM

Benjamin Mack benni at typo3.org
Sat May 29 12:21:40 CEST 2010


Hey guys,

just so you know: The $frame parameter was moved OUT of the wrap 
filename because of a problem with the frames [0] when using safe_mode 
on Unix machines. This was a major bug and was introduced with 4.3.1 (I 
think), and fixed with 4.3.2. So, please don't make the same mistake again.

On 29.05.10 11:12, Jigal van Hemert wrote:
> -			$cmd = t3lib_div::imageMagickCommand('convert', $params . ' ' . $this->wrapFileName($input) . $frame . ' ' . $this->wrapFileName($output));
> +			$cmd = t3lib_div::imageMagickCommand('convert', $params . ' ' . $this->wrapFileName($input . $frame) . ' ' . $this->wrapFileName($output));

I think that we need to have this patch tested on

  * Unix + Windows
  * safe_mode on/off
  * PDF thumbnail generation / GIFBuilder

to be complete.

All the best,
benni.


More information about the TYPO3-team-core mailing list