[TYPO3-core] RFC #14324: Feature: Add spriteGeneratorAPI to support the new sprite-icon-api

Steffen Kamper info at sk-typo3.de
Fri May 21 14:00:54 CEST 2010


Hi,

Susanne Moog schrieb:
> Hi,
> 
> On 15.05.2010 01:16, Steffen Kamper wrote:
>> Hi Steffen,
>>
>> i did some additional cleaning in attached patch.
> 
> in general +1 by reading and testing, with some variable names nitpicking:
> 
> - $allowedCSSFilesinTempDir -> should be $allowedCssFilesinTempDir
> - $TCAtables -> should be $tcaTables (later $tcaCtrl is used --> more
> consistent to always use lowercase for the first part)
> - $styleSheetTemplateTCA -> $styleSheetTemplateTca
> 
> Steffen, would you take care of the commit?
> 

yes, i will commit the API tonight. Thanks for the review.

Steffen, could you provide a correct patch for the sprite usage in core 
(new RFC), maybe respecting the remarks from Helmut?

vg Steffen


More information about the TYPO3-team-core mailing list