[TYPO3-core] RFC: #14396: Warn when KEEP_FILE is set

[Helmut Hummel]

Hi,

On 16.05.10 01:46, Steffen Kamper wrote:
> 
> this is SVN patch request.
> 
> Type: bugfix
> 
> Branches: trunk
> 
> BT reference: http://bugs.typo3.org/view.php?id=14396
> 
> When the ENABLE_INSTALL_TOOL file contents "KEEP_FILE" it won't be deleted.
> 
> Show flash message in setup when this is set.
> Disable the delete button (submit would create an error)

-1 for the current implementation.


That's why:

* The warning messeage renders the warning every time, even if the setup
was called just to change passwords.

* Although it works it looks strange to me that the introduced
properties are protected, but are used in a not protected context
($parent->installToolFileExists)

* although there is the warning, I find it strange that the button looks
the same (even if it's disabled). Btw. even with Steffen Geberts patch,
the mouse cursor still turns into a pointer when hovering the button.


I suggest to not render the flash message, but render a warning sign on
the disabled button with a tooltip that contains the text of the flash
message.

The protected properties should get a public getter which should be
called from the outside.

Regards Helmut