[TYPO3-core] RFC: #14860: Pagerenderer - use better method for adding meta tags

Jigal van Hemert jigal at xs4all.nl
Fri Jun 25 08:15:57 CEST 2010


Steffen Kamper wrote:
> atm meta tags are added with complete html tag.
> The better method would be to add tags with a name and the content.

Attached version 2 with:
- CGL on comments (space after //)
- use of API functions t3lib_div::isFirstPartOfStr(), t3lib_div::inArray()
- meaningful variable names $additionalAttributes, $attributeName, 
$attributeValue

+1 by reading and testing (version 2)

@Olli : this one would be a great candidate for a unit test, but it 
doesn't return anything. How can that be handled???

-- 
Jigal van Hemert
skype:jigal.van.hemert
msn: jigal at xs4all.nl
http://twitter.com/jigalvh
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 14860_v2.diff
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100625/bd5f5bf6/attachment.asc>


More information about the TYPO3-team-core mailing list