[TYPO3-core] RFC: #14824: Sprite API: Still a wrong icon (Template Analyzer)

[Susanne Moog]

On 26.06.2010 09:51, Jigal van Hemert wrote:
> Georg Ringer wrote:
>> Problem:
>> There is a wrong icon in the template analyer
> 
> Although this seems to work, the problem lies in
> t3lib_iconWorks::mapRecordOverlayToSpriteIconName() and the code which
> calls it in this case, t3lib_tsparser_ext::ext_getTemplateHierarchyArr()
> (line 603).
> t3lib_iconWorks::mapRecordOverlayToSpriteIconName() should be called
> with the record row, not a single field of that row. If you pass
> $row['root'] to it, depending on the value which is passed the code
> still assumes that this is an array and start to analyse elements of
> this array. If $row['root'] is for example '1' this value results in the
> check for the 'hidden' field to succeed and thus the hidden overlay icon
> will be shown.
> 
> The attached patch fixes the code in t3lib_tsparser_ext and results in
> the correct icon to be shown.
> 
> Still mapRecordOverlayToSpriteIconName() needs to be repaired so it will
> not treat any value for $row as an array.

committed to 4_4 and trunk (after my +1 by reading and testing) rev
8100, 8101

Susanne