[TYPO3-core] RFC #14028: Code cleanup: Cleanup: class.t3lib_userauthgroup.php

Xavier Perseguers typo3 at perseguers.ch
Wed Apr 21 10:49:15 CEST 2010


Hi,

> Kjeld Schumacher wrote:
>> ok, I splitted them in three parts, see attachments. I hope I did not
>> missed something.
>
> I got a small change in the variables patch: we try to return the value
> only once in the function, so I fixed that and refactored variuable names
> even more inside isPSet() function.
>
> Patches get my +1 by reading (variables patch also by testing).

I'd like to read "public" in front of the method in addition to reflect change in @access. Needs to be done at commit time only!

Thanks.

-- 
Xavier Perseguers
http://xavier.perseguers.ch/en


More information about the TYPO3-team-core mailing list