[TYPO3-core] RFC: Bug #13471: List module eats up tons of memory if displaying records with many references

[Oliver Klee]

Hi,

I like the concept a lot!

I haven't tested this yet (or reviewed it), but just CGL-updated and
refactored the trunk patch:

- added @var for $references, var -> public, and made the end-line
comment a documentation comment
- added proper documentation comments to $referenceCount
- add spaces around =
- clean up and and improve the documentation comments for getReferenceCount
- use exec_SELECTcountRows instead of exec_SELECTgetRows
- remove the now-unused local variable $referenceCount from
getReferenceCount
- drop the intval from $uid because the function API already requires a UID
- $table -> $tableName
- use proper camel case: getReferenceHTML -> createReferenceHtml
- clean up and improve the documentation comments for createReferenceHtml
- use a guard clause in createReferenceHtml
- use a break for checking the cumulative title length instead of
putting it in the while condition
- use sql_fetch_assoc instead of sql_fetch_row to make the array indices
more readable



Oli
-- 
Certified TYPO3 Integrator | TYPO3 Security Team Member
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 13471_03_trunk.diff
Type: text/x-patch
Size: 6748 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100418/b684d03e/attachment.bin>