[TYPO3-core] RFC: Bug 5678: Missing clearer div in csc-textpic-intext-left/csc-textpic-intext-right

[Dmitry Dulepov]

Hi!

Ernesto Baschny [cron IT] wrote:
> The particular change to the template is there and properly documented
> and can be fetched:
> 
> svn diff -c7350 typo3/sysext/css_styled_content/static/setup.txt

Will you remember this after a year? I bet you will not.

I do not talk about two RFCs due to some abstract logic. Some time ago I
had to fix a bug introduced in the newer version of the crawler. There was
exactly this style of commits: cryptic unrelated messages, many changes in
one, huge patches. I spent 1.5 days trying to find where they introduced a
one line bug in tons of committed code. I do not want that for the core. It
IS a mess. It is not the way the software should be developed. We must do
better!

In a year or two no one should be able to tell exactly what the commit
changed and why. This particular commit did a huge line count change, where
a useful fix is obscured by a long code. Nobody will be able to find the
real fix in this huge patch: exactly the problem I fought in crawler.

> The patch also contains the proper hooks into the Upgrade Wizard, so
> everybody will know what happens.

Even more code...

> So while I respect your opinion and understand your arguments, I don't
> feel that the good job Susanne did on this matter (which was already
> slipping into the CSS-hacks scene) deserves your harsh and inpolite
> wording ("thanks for the mess").

I hope that my harsh words will make our procedures better. This is why I
wrote them. I already explained in this thread why it should be two RFCs
but it was ignored without a single comment. If I were an RM or a core team
leader, I would use the other power to enforce commit rules. I do not have
any power, so I can only provoke you all a little to look more into quality.

I am thankful to Susanne for all great work she does but we must be more
careful. It is not a game. We are famous for our quality and we have to
keep that. One way to keep quality is to ensure that our commits do only
one thing per commit (unless two things are like two lines).

Again and again: I am not doing this of some stupid reason but because it
is very important for TYPO3 to keep a clear history of all changes.

-- 
Dmitry Dulepov
TYPO3 expert / TYPO3 security team member
Read more @ http://dmitry-dulepov.com/