[TYPO3-core] RFC: Feature #14098: When sending mail, use TYPO3_CONF_VAR for default from address if no other address is provided

[Dmitry Dulepov]

Hi!

I forgot to tell that I did not test, just looked.

Dmitry Dulepov wrote:
> This line is not ok:
> 
> +		if (!preg_match('/^From:/', $additionalHeaders) &&
> 
> It does not work with this $additionaHeaders:
> 
> 	$additionaHeaders = 'Organization: MyCompany' . chr(10) .
> 		'From: me at me.com';
> 
> And does not work with this:
> 	$additionaHeaders = 'from: me at me.com';
> 
> Better would be:
> 
> +		if (!preg_match('/^From:/im', $additionalHeaders) &&
> 

-- 
Dmitry Dulepov
TYPO3 expert / TYPO3 security team member
Read more @ http://dmitry-dulepov.com/