[TYPO3-core] RFC #13988: bugfix/code cleanup: (NO duplicate) wrong image dimension returned if alternative logo is set and skin-extension is installed in global-space (backend-redesign) #2

Stephan N Kellermayr stephan.kellermayr at t3x.at
Thu Apr 1 10:00:47 CEST 2010


this is an SVN patch request.

type: bugfix/code cleanup

bugtracker references:
http://bugs.typo3.org/view.php?id=13988

branches:
trunk, current branch

problem:
if an alternative TYPO3-logo is set in $GLOBALS['TBE_STYLES']['logo'] 
and a skin-extension is installed in 'typo3/ext/' (globally), the file 
'typo3/backend.php' does not check the image-dimensions. instead it 
outputs the alternative image with the size of the default logo.

and i am sorry, i dont know where the function 'getLogo' is actually 
used (maybe it is deprecated?), so i dont know how to test it, because 
the logo-image on the upper left is processed by 
'typo3/classes/class.typo3logo.php'.
...BUT: the file 'typo3/backend.php' just contains the same issue as 
reported in http://bugs.typo3.org/view.php?id=13985


solution:
just remove the substring-check '../', resolve the backpath to the 
alternative logo-file and always run through 'getimagesize'.


notes:
none

best regards,
Stephan N Kellermayr
-------------- next part --------------
A non-text attachment was scrubbed...
Name: backend.php.0013988.diff
Type: text/x-patch
Size: 1031 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100401/d7874ce8/attachment.bin>


More information about the TYPO3-team-core mailing list