[TYPO3-core] RFC: #8980: unlink of non existant lockfiles generates warnings in frontend

[Susanne Moog]

Hi Masi,

Martin Kutschker schrieb:
> Rupert Germann schrieb:
>> hi Susanne,
>>
>> wouldn't an @ sign at the beginning of unlink have the same effect?
>> if (@unlink($this....
> 
> I'd choose this way too, but... Where did the lockfile go?

That's the master question. I have not noted any pattern concerning
these warnings, but I had a look in the code and can at least guess what
is happening:

On acquiring the lock the acquire function tries to create the lock file
via touch(). If touch() fails (why it would do so I don't know) an
exception is thrown but the lock state is set to acquired anyway. So
when TYPO3 now attempts to release the lock file it results in a warning
because there is no file to unlink.

(I don't know what happens if the files in the lock directory are
deleted manually or through the install tool, perhaps this would be
another way to trigger the bug)

HTH,

Susanne

-- 
Susanne Moog
NEUSTA GmbH - www.neusta.de