[TYPO3-core] RFC: #10045 BUG missleading Errormessage with emtpy COA

[Michael Stucki]

Let's discuss this off-list.

- michael

Steffen Kamper schrieb:
> Hi Ingo , Michael,
> 
> i didn't saw a problem with this change even without includeLibs in 4_2
> as the patch only adds a proper Errormessage with an empty COA.
> 
> So i'm not sure where you see the problem.
> 
> As original RFC is bugfix only and was done for 4_2 and trunk i thought
> that we will fix bugs in older versions too. Ok, the includeLibs was my
> fault that i reverted immediately. The change i did manually as the
> patch (of course) didn't apply to 4_2
> 
> vg Steffen
> 
> Ingo Renner schrieb:
>> Steffen Kamper wrote:
>>
>> Steffen,
>>
>>> committed to 4_2 and trunk, rev 4883/4884
>>
>> I have to ask you to be more cautious with your commits! With this
>> commit you introduced that call to includeLibs() which is not
>> available in 4.2. Fortunately you noticed that yourself.
>>
>> However as Stucki and me are at reviewing all the changes made since
>> the last versions it is very work intesive to follow these things.
>>
>> The patch as provided by Ingo was against trunk and thus included the
>> call to includeLibs() as it was in the ADD part of the hunk due to
>> everything being indented one level.
>> You have to be careful with this especially when applying such patches
>> to older branches.
>>
>> In such cases please use the ignore whitespace option of diff, this
>> would have revealed this change immediately!
>>
>>
>> best
>> Ingo
>>


-- 
Use a newsreader! Check out
http://typo3.org/community/mailing-lists/use-a-news-reader/