[TYPO3-core] Feature #9633: Implement autoloading for TYPO3

Xavier Perseguers typo3 at perseguers.ch
Sun Apr 26 16:50:01 CEST 2009


Hi,

> Notes:
> This patch is part of a patch series to implement the autoloader. The 
> patches have been worked out together with Olly, based on work by 
> Dmitry, Ingo, Ingmar, Masi and Jochen.

A few spots after a "quick" overlook:

1) Wrong CGL
    $this->content.=$this->doc->section('',$content,0,1);

(and a few others too)

2) I thought we had to use foreach:
    while (list(,$token) = each($tokenList)) {

3)

Property changes on: mod1/class.tx_extdeveval_buildautoloadregistry.php
___________________________________________________________________
Added: svn:executable

Property changes on: t3lib/core_autoload.php
___________________________________________________________________
Added: svn:executable

Is this really needed?


4)

+ * @author	Dmitry Dulepov	<dmitry at typo3.org>
+ * @author	Martin Kutschker <masi at typo3.org>
+ * @author	Oliver Hader <oliver at typo3.org>
+ * @author  Sebastian Kurfürst <sebastian at typo3.org>

Wrong indent for last author


5)
+		$errors[] = 'Wrote the following data: <pre>' . 
htmlspecialchars($autoloadFileString) . '</pre>';
+		return implode('<br />', $errors);
+	}
+	/**
+	 * Build the autoload registry for the core.
+	 * That includes:
+	 * - t3lib/
+	 * - tslib/
+	 * - the "lang" sysext
+	 *
+	 * @return	string	HTML string which should be outputted
+	 */
+	public function createAutoloadRegistryForCore() {

Missing empty line between end of previous method and comment of method 
createAutoloadRegistryForCore()

-- 
Xavier Perseguers
http://xavier.perseguers.ch/en

One contribution a day keeps the fork away


More information about the TYPO3-team-core mailing list