[TYPO3-core] RFC #7984: Bug: stdWrap.crop now closes opened tags and counts chars correctly

Dmitry Dulepov [typo3] dmitry at typo3.org
Fri Sep 5 17:26:28 CEST 2008


Hi!

Martin Kutschker wrote:
> The regex works only on limited predefined list of tags without any
> apparent reason. I think it can be done without it (just replace the tag
> list with [a-z]+ or [a-zA-Z]+ (both for old HTML and custom XHTML tags).
> Anyway, if the list stays it should at least be extended to cover also
> thead, tbody and tfoot (didn't check against the complete list of xhtml
> tags). Nah, the list must go: it's hard to maintain, not forward
> compatible, not compatible with custom tags).
> 
> Works only for character sets supported by html_entity_decode().
> 
> Nitpick: abs() is applied a multiple times to max. string length.
> 
> Masi
> 
> PS: I find this piece of code surprisingly hard to read.

Well, another cool feature is not getting in... :(

-- 
Dmitry Dulepov
TYPO3 Core team
My TYPO3 book: http://www.packtpub.com/typo3-extension-development/book
In the blog: http://typo3bloke.net/pages/book-reviews/presentation-zen-by-garr-reynolds/


More information about the TYPO3-team-core mailing list