[TYPO3-core] RFC: #9372: Code in class.tx_tstemplateanalyzer.php don't match with the new CGL

Stefano Kowalke blueduck at gmx.net
Sun Nov 2 20:40:00 CET 2008


Steffen Kamper wrote:

> Hi,
> 
> Stefano Kowalke schrieb:
>> Francois Suter wrote:
>> 
>>> Hi Stefano,
>>>
>>>> i updated the patch a little bit.
>>>>
>>>> * update file comment
>>>> * adding class comment
>>>> * give the inline comments same idention like the code and if was
>>>> necessary put them one line above the dedicated code, not behind.
>>> Thanks for your work, but we don't have *official* new CGLs yet, so I
>>> think it's a bit premature to push this patch. Sorry.
>>>
>>> Cheers
>>>
>> 
>> But we have a inofficial new CGL from Dmitry and i think the main topics
>> covered by this and if some day come a official CGL only small changes
>> was changed.
>> 
>> Stefano
> 
> I also see no reason to wait as we all know about most of CGL.
> 
> Anyway the patch has strange line endings, i can't apply this way. Could
> you have a look again please?
> 
> vg Steffen

What do you mean with 'strange line endings'? Settings in Eclipse are Unix. 
Could you give me a hint, maybe the output from patch.

Stefano
-- 
Seit dem 1.1.2008 werden Daten zu jeder E-Mail verdachtsunabhängig gespeichert! 
Weitere Informationen: www.vorratsdatenspeicherung.de
GPG-ID: 0x2B08936D
Key-Fingerprint: 7F31 BCF0 70C0 B3B1 1235 07E9 1777 D7A0 2B08 936D


More information about the TYPO3-team-core mailing list