[TYPO3-core] RFC: #7816: New page icon does not honor a selected page (Pagetree)

[Steffen Kamper]

Hi Benni,

"Benjamin Mack" <benni at typo3.org> schrieb im Newsbeitrag 
news:mailman.1.1205241054.20522.typo3-team-core at lists.netfielders.de...
> Hey Steffen,
>
> thanks for taking care of this.
>
> Some sidenotes to the patch:
>
> * function name getPageID() -- if I read getPageID() I think that the
> pageID is returned (old java habit ;-)), either rename the function to
> "extractPageIDfromTreeItem()" or return the pageID. I'd favor the first
> one. And: remove the extra line break when calling this function in the 
> two
>
i renamed function to your suggestion

> * getPageID() #2: the tmp variable is unnecessary, just do a direct
> assignment.
>
did it in one line

> Apart from that, +1 after reading. Just make sure that the Tree class
> does not throw any errors when called in the filelist or somewhere else
> where there are no "pageIDs". Also, please add some documentation above
> the function declaration.
>

i documented the function. Errors can't be thrown as i ask for
if(highlightID) { ...
so this highlightID contains the id, all pagetrees are generated with same 
class so this is identic all the time.

thx, new patch is attached.

vg  Steffen 


begin 666 7816_newpage_no_id2.diff
M26YD97 at Z('1Y<&\S+V%L=%]D8E]N879F<F%M92YP:' -"CT]/3T]/3T]/3T]
M/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]
M/3T]/3T]/3T]/3T-"BTM+2!T>7!O,R]A;'1?9&)?;F%V9G)A;64N<&AP"2AR
M979I<VEO;B S-# T*0T**RLK('1Y<&\S+V%L=%]D8E]N879F<F%M92YP:' )
M*'=O<FMI;F<@8V]P>2D-"D! ("TR-C L-R K,C8P+#<@0$ -"B )"2D["B *
M( D)"2\O($YE=R!086=E"BT)"21O;F-L:6-K3F5W4&%G95=I>F%R9" ]("=T
M;W N8V]N=&5N="YL:7-T7V9R86UE+FQO8V%T:6]N+FAR968]=&]P+E13+E!!
M5$A?='EP;S,K7"=D8E]N97<N<&AP/VED/3$F<&%G97-/;FQY/3%<)SLB)SL*
M*PD))&]N8VQI8VM.97=086=E5VEZ87)D(#T@)W1O<"YC;VYT96YT+FQI<W1?
M9G)A;64N;&]C871I;VXN:')E9CUT;W N5%,N4$%42%]T>7!O,RM<)V1B7VYE
M=RYP:' _<&%G97-/;FQY/3$F:60]7"<K5')E92YP86=E240[(B<["B )"21B
M=71T;VYS6R=N97=?<&%G92==(#T@)SQA(&AR968](B,B(&]N8VQI8VL](B<@
M+B D;VYC;&EC:TYE=U!A9V57:7IA<F0 at +B G(CX\:6UG)R N('0S;&EB7VEC
M;VY7;W)K<SHZ<VMI;DEM9R at G)RP@)V=F>"]N97=?<&%G92YG:68G*2 N("<@
M=&ET;&4](B<@+B D3$%.1RT^<TPH)TQ,3#I%6%0Z8VUS+VQA>6]U="]L;V-A
M;&QA;F<N>&UL.FYE=U!A9V4G+" Q*2 N("<B(&%L=#TB(B O/CPO83XG.PH@
M"B )"0DO+R!2969R97-H"DEN9&5X.B!T>7!O,R]J<R]T<F5E+FIS#0H]/3T]
M/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]
M/3T]/3T]/3T]/3T]/3T]/3T]#0HM+2T@='EP;S,O:G,O=')E92YJ<PDH<F5V
M:7-I;VX@,S0P-"D-"BLK*R!T>7!O,R]J<R]T<F5E+FIS"2AW;W)K:6YG(&-O
M<'DI#0I 0" M,S8L-R K,S8L."! 0 T*( EF<F%M95-E=$UO9'5L93H@;G5L
M;"P*( EA8W1I=F%T941R86=$<F]P.B!T<G5E+ H@"6AI9VAL:6=H=$-L87-S
M.B G86-T:79E)RP*+0HK"7!A9V5)1#H@,"P**PD*( DO+R!R96QO861S(&$@
M<&%R="!O9B!T:&4@<&%G92!T<F5E("AU<V5F=6P@=VAE;B B97AP86YD(B O
M(")C;VQL87!S92(I"B );&]A9#H at 9G5N8W1I;VXH<&%R86US+"!I<T5X<&%N
M9"P@;V)J*2!["B )"0DO+R!F86QL8F%C:R!I9B!!2D%8(&ES(&YO="!P;W-S
M:6)L92 H92YG+B!)12 \(#8I"D! ("TQ,#0L,30@*S$P-2PQ."! 0 T*( DO
M+R!S96QE8W1S('1H92!A8W1I=F%T960@:71E;2!A9V%I;BP@:6X at 8V%S92!I
M="!C;VQL87!S960 at 86YD(&=O="!E>'!A;F1E9"!A9V%I;@H@"7)E4V5L96-T
M06-T:79E271E;3H at 9G5N8W1I;VXH*2!["B )"6]B:B ]("0H=&]P+F9S36]D
M+FYA=D9R86UE2&EG:&QI9VAT961)1%MT:&ES+F9R86UE4V5T36]D=6QE72D[
M"BT)"6EF("AO8FHI($5L96UE;G0N861D0VQA<W-.86UE*&]B:BP@=&AI<RYH
M:6=H;&EG:'1#;&%S<RD["BL)"6EF("AO8FHI('L**PD)"45L96UE;G0N861D
M0VQA<W-.86UE*&]B:BP@=&AI<RYH:6=H;&EG:'1#;&%S<RD["BL)"0ET:&ES
M+F5X=')A8W1086=E241F<F]M5')E94ET96TH;V)J+FED*3L**PD)?0H@"7TL
M"B *( DO+R!H:6=H;&EG:'1S(&%N(&%C=&EV92!L:7-T(&ET96T@:6X@=&AE
M('!A9V4@=')E92!A;F0@<F5G:7-T97)S(&ET('1O('1H92!T;W M9G)A;64*
M( DO+R!U<V5D('=H96X@;&]A9&EN9R!T:&4@<&%G92!F;W(@=&AE(&9I<G-T
M('1I;64*( EH:6=H;&EG:'1!8W1I=F5)=&5M.B!F=6YC=&EO;BAF<F%M95-E
M=$UO9'5L92P@:&EG:&QI9VAT240I('L*( D)=&AI<RYF<F%M95-E=$UO9'5L
M92 ](&9R86UE4V5T36]D=6QE.PHM"BL)"71H:7,N97AT<F%C=%!A9V5)1&9R
M;VU4<F5E271E;2AH:6=H;&EG:'1)1"D["BL)"0H@"0DO+R!296UO=F4 at 86QL
M(&ET96US('1H870 at 87)E(&%L<F5A9'D@:&EG:&QI9VAT960*( D);V)J(#T@
M)"AT;W N9G--;V0N;F%V1G)A;65(:6=H;&EG:'1E9$E$6V9R86UE4V5T36]D
M=6QE72D["B )"6EF("AO8FHI('L*0$ @+3$R,RPV("LQ,C at L,3, at 0$ -"B )
M"2\O(%-E="!T:&4@;F5W(&ET96T*( D)=&]P+F9S36]D+FYA=D9R86UE2&EG
M:&QI9VAT961)1%MF<F%M95-E=$UO9'5L95T@/2!H:6=H;&EG:'1)1#L*( D)
M:68@*"0H:&EG:&QI9VAT240I*2!%;&5M96YT+F%D9$-L87-S3F%M92AH:6=H
M;&EG:'1)1"P@=&AI<RYH:6=H;&EG:'1#;&%S<RD["BL)?2P**PD**PDO+V5X
M=')A8W0@<&%G94E$(&9R;VT@=&AE(&=I=F5N(&ED("AP86=E<WAX>%]Y7WH@
M=VAE<F4@>'AX(&ES('1H92!)1"D**PEE>'1R86-T4&%G94E$9G)O;51R965)
M=&5M.B!F=6YC=&EO;BAH:6=H;&EG:'1)1"D@>PHK"0EI9BAH:6=H;&EG:'1)
M1"D@>PD**PD)"71H:7,N<&%G94E$(#T@:&EG:&QI9VAT240N<W!L:70H)U\G
B*5LP72YS=6)S=')I;F<H-2D["BL)"7T*( E]"B!].PH@"@``
`
end