[TYPO3-core] RFC: #7536: Docheaders: Wizard Forms: No docheader

Oliver Hader oh at inpublica.de
Fri Feb 15 10:41:07 CET 2008


Hi Patrick,

Patrick Broens schrieb:
> Problem:
> Wizard Forms has no docheader and is not according to new BE user interface
> 
> Solution:
> Add docheader to wizard
> 
> Branches:
> Trunk, TYPO3_4-2
> 
> BT Reference: http://bugs.typo3.org/view.php?id=7536

Thanks for your patch. I have some small annotations (similar to my 
previous posts ;) ):

      function printContent()    {
-        $this->content.= $this->doc->endPage();
-        $this->content = $this->doc->insertStylesAndJS($this->content);

--> Please let these calls in printContent() since existing extensions 
which XCLASS this module might rely on it

+    private function getButtons()    {
+        global $LANG, $BACK_PATH;

--> $BACK_PATH isn't used in this function, thus you could remove it 
from the global statement

Thanks in advance for changing the mentioned things!
When done so: +1 on testing and reading

olly
-- 
Oliver Hader
http://inpublica.de/


More information about the TYPO3-team-core mailing list