[TYPO3-core] RFC #8505: String "Important Notice" in About Modules is hardcoded

Tue Aug 19 20:20:56 CEST 2008

Another one that is practically ready to go. I think it should not be 
lost...

Here is Dmitry's patch again; again against current trunk.

Cheers!

Christopher

"Dmitry Dulepov [typo3]" <dmitry at typo3.org> schrieb im Newsbeitrag 
news:mailman.1.1211788941.30229.typo3-team-core at lists.netfielders.de...
> Hi!
>
> Steffen Ritter wrote:
>> Branches:
>> 4.2, Trunk
>
> May be 4.1 too?
>
>> Problem:
>> The label in the warning box, located About modules called "Important
>> notice!" is hardcoded and a space befor (next to the image) is missing.
>>
>> Solution:
>> attached patch
>
> Visually looks ok and works. But I dislike using &nbsp; for visual space: 
> it does not look like a right tool for the job and does not allow further 
> styling of warning header. Can we introduce a new style instead? See the 
> attached patch.
>
> Additionally I made sure that this piece of code follows coding 
> guidelines.
>
> -- 
> Dmitry Dulepov
> TYPO3 core team
> Web: http://typo3bloke.net/
> "Nothing is impossible. There are only limits to our knowledge"
>

--------------------------------------------------------------------------------

> Index: t3lib/class.t3lib_befunc.php
> ===================================================================
> --- t3lib/class.t3lib_befunc.php (revision 3716)
> +++ t3lib/class.t3lib_befunc.php (working copy)
> @@ -3958,9 +3958,11 @@
>
>  if (count($warnings)) {
>  $style = ' style="margin-bottom:10px;"';
> - $content = '<table border="0" cellpadding="0" cellspacing="0" 
> class="warningbox"><tr><td>'.
> - $GLOBALS['TBE_TEMPLATE']->icons(3).'Important notice!<br 
> /><ul><li'.$style.'>'.
> - implode('</li><li'.$style.'>', $warnings).'</li></ul>'.
> + $content = '<table border="0" cellpadding="0" cellspacing="0" 
> class="warningbox"><tr><td>' .
> + $GLOBALS['TBE_TEMPLATE']->icons(3) . '<span class="warningboxheader">' .
> + $GLOBALS['LANG']->sL('LLL:EXT:lang/locallang_core.xml:warning.header') .
> + '</span><br /><ul><li' . $style.'>' .
> + implode('</li><li' . $style . '>', $warnings) . '</li></ul>' .
>  '</td></tr></table>';
>
>  unset($warnings);
> Index: typo3/stylesheet.css
> ===================================================================
> --- typo3/stylesheet.css (revision 3716)
> +++ typo3/stylesheet.css (working copy)
> @@ -2386,6 +2386,9 @@
>  margin: 10px 0px 10px 0px;
> }
>
> +span.warningboxheader {
> + margin-left: 5px;
> +}
>
> /* - - - - - - - - - - - - - - - - - - - - -
>
> Index: typo3/sysext/lang/locallang_core.xml
> ===================================================================
> --- typo3/sysext/lang/locallang_core.xml (revision 3716)
> +++ typo3/sysext/lang/locallang_core.xml (working copy)
> @@ -195,6 +195,7 @@
>  <label index="warning.install_enabled_cmd">Click to remove the file 
> now!</label>
>  <label index="warning.install_encryption">The encryption key is not set. 
> Set it in the %sBasic Configuration section%s of the Install Tool.</label>
>  <label index="warning.install_update">This installation is not configured 
> for the TYPO3 version it is running. If you did so intentionally, this 
> message can be safely ignored. If you are unsure, visit the %sUpdate 
> Wizard%s section of the Install Tool to see how TYPO3 would 
> change.</label>
> + <label index="warning.header">Important Notice!</label>
>  <label index="warning.backend_reference">The Reference Index table is 
> empty which is likely the result of a recent TYPO3 upgrade. Please go to 
> %sTools&gt;DB Check%s and update the reference index.</label>
>  </languageKey>
>  </data>
> 

begin 666 8505_2.diff
M+2TM('0S;&EB+V-L87-S+G0S;&EB7V)E9G5N8RUO<FEG+G!H< DR,# X+3 X
M+3$Y(#$X.C$S.C0S+C P,# P,# P," K,#(P, T**RLK('0S;&EB+V-L87-S
M+G0S;&EB7V)E9G5N8RYP:' ),C P."TP."TQ.2 Q.#HQ.3HR-"XP,# P,# P
M,# @*S R,# -"D! ("TS.3<Q+#D@*S,Y-S$L,3$@0$ -"@T*( D)"6EF("AC
M;W5N="@D=V%R;FEN9W,I*2![#0H@"0D)"21S='EL92 ]("<@<W1Y;&4](FUA
M<F=I;BUB;W1T;VTZ,3!P>#LB)SL-"BT)"0D))&-O;G1E;G0@/2 G/'1A8FQE
M(&)O<F1E<CTB,"(@8V5L;'!A9&1I;F<](C B(&-E;&QS<&%C:6YG/2(P(B!C
M;&%S<STB=V%R;FEN9V)O>"(^/'1R/CQT9#XG+ at T*+0D)"0D))$=,3T)!3%-;
M)U1"15]414U03$%412==+3YI8V]N<R at S*2XG26UP;W)T86YT(&YO=&EC92$\
M8G(@+SX\=6P^/&QI)RXD<W1Y;&4N)SXG+ at T*+0D)"0D):6UP;&]D92 at G/"]L
M:3X\;&DG+B1S='EL92XG/B<L("1W87)N:6YG<RDN)SPO;&D^/"]U;#XG+ at T*
M*PD)"0DD8V]N=&5N=" ]("<\=&%B;&4 at 8F]R9&5R/2(P(B!C96QL<&%D9&EN
M9STB,"(@8V5L;'-P86-I;F<](C B(&-L87-S/2)W87)N:6YG8F]X(CX\='(^
M/'1D/B<@+ at T**PD)"0D))$=,3T)!3%-;)U1"15]414U03$%412==+3YI8V]N
M<R at S*2 N("<\<W!A;B!C;&%S<STB=V%R;FEN9V)O>&AE861E<B(^)R N#0HK
M"0D)"0DD1TQ/0D%,4ULG3$%.1R==+3YS3"@G3$Q,.D585#IL86YG+VQO8V%L
M;&%N9U]C;W)E+GAM;#IW87)N:6YG+FAE861E<B<I("X-"BL)"0D)"2<\+W-P
M86X^/&)R("\^/'5L/CQL:2<@+B D<W1Y;&4N)SXG("X-"BL)"0D)"6EM<&QO
M9&4H)SPO;&D^/&QI)R N("1S='EL92 N("<^)RP@)'=A<FYI;F=S*2 N("<\
M+VQI/CPO=6P^)R N#0H@"0D)"0DG/"]T9#X\+W1R/CPO=&%B;&4^)SL-"@T*
M( D)"0EU;G-E="@D=V%R;FEN9W,I.PT*0$ @+30P.3,L-" K-# Y-2PT($! 
M#0H@"0ER971U<FX@)'-C<FEP=#L-"B )?0T*('T-"BT_/@T**S\^#0I<($YO
M(&YE=VQI;F4 at 870@96YD(&]F(&9I;&4-"BTM+2!T>7!O,R]S='EL97-H965T
M+6]R:6<N8W-S"3(P,#@M,#@M,3D@,3 at Z,C$Z,30N,# P,# P,# P("LP,C P
M#0HK*RL@='EP;S,O<W1Y;&5S:&5E="YC<W,),C P."TP."TQ.2 Q.3HQ,CHP
M."XP,# P,# P,# @*S R,# -"D! ("TR-#$U+#8@*S(T,34L,3 @0$ -"B )
M;6%R9VEN.B Q,'!X(#!P>" Q,'!X(#!P>#L-"B!]#0H-"BMS<&%N+G=A<FYI
M;F=B;WAH96%D97(@>PT**PEM87)G:6XM;&5F=#H at -7!X.PT**WT-"BL-"@T*
M("\J("T at +2 M("T at +2 M("T at +2 M("T at +2 M("T at +2 M("T at +2 M("T at +2 M
M#0H-"BTM+2!T>7!O,R]S>7-E>'0O;&%N9R]L;V-A;&QA;F=?8V]R92UO<FEG
M+GAM; DR,# X+3 X+3$Y(#$Y.C0U.C,T+C P,# P,# P," K,#(P, T**RLK
M('1Y<&\S+W-Y<V5X="]L86YG+VQO8V%L;&%N9U]C;W)E+GAM; DR,# X+3 X
M+3$Y(#$Y.C0V.C$Y+C P,# P,# P," K,#(P, T*0$ @+3(P-2PV("LR,#4L
M-R! 0 T*( D)"3QL86)E;"!I;F1E>#TB8VTN8V]P>49O;&1E<E]I;G1O(CY#
M;W!Y(&9O;&1E<B!I;G1O/"]L86)E;#X-"B )"0D\;&%B96P@:6YD97@](F-M
M+FUO=F5&;VQD97)?:6YT;R(^36]V92!F;VQD97(@:6YT;SPO;&%B96P^#0H@
M"0D)/&QA8F5L(&EN9&5X/2)C;2YC<F5A=&5.97=296QA=&EO;B(^0W)E871E
M(&YE=R!R96QA=&EO;CPO;&%B96P^#0HK"0D)/&QA8F5L(&EN9&5X/2)W87)N
M:6YG+FAE861E<B(^26UP;W)T86YT($YO=&EC92$\+VQA8F5L/@T*( D)"3QL
M86)E;"!I;F1E>#TB=V%R;FEN9RYI;G-T86QL7W!A<W-W;W)D(CY4:&4 at 26YS
M=&%L;"!4;V]L(&ES('-T:6QL('5S:6YG('1H92!D969A=6QT('!A<W-W;W)D
M("9Q=6]T.VIO:#,Q-B9Q=6]T.RX at 57!D871E('1H:7,@=VET:&EN('1H92 E
M<T%B;W5T('-E8W1I;VXE<R!O9B!T:&4 at 26YS=&%L;"!4;V]L+CPO;&%B96P^
M#0H@"0D)/&QA8F5L(&EN9&5X/2)W87)N:6YG+F)A8VME;F1?861M:6XB/E1H
M92!D969A=6QT(&)A8VME;F0@=7-E<B B861M:6XB('=I=&@@<&%S<W=O<F0@
M)G%U;W0[<&%S<W=O<F0F<75O=#L@:7,@<W1I;&P@<')E<V5N="X@)7-%9&ET
M('1H:7, at 86-C;W5N="5S+"!E:71H97(@9&5L971I;F<@:70 at 8V]M<&QE=&5L
M>2!O<B!C:&%N9VEN9R!T:&4@=7-E<FYA;64 at 86YD('!A<W-W;W)D+CPO;&%B
M96P^#0H@"0D)/&QA8F5L(&EN9&5X/2)W87)N:6YG+F9I;&5?9&5N>5]P871T
M97)N(CY4:&4@=F%L=64@;V8 at 9FEL941E;GE0871T97)N(&ES(&YO="!S970@
M=&\@:71S(&1E9F%U;'0Z)7, at 268@5%E03S,@:7,@<G5N;FEN9R!O;B!!<&%C
M:&4L(&$@8W5S=&]M:7IE9"!V86QU92!M:6=H="!E;F%B;&4 at 8F%C:V5N9"!O
M<B!F<F]N=&5N9"!U<V5R<R!T;R!E>&5C=71E(&UA;&EC:6]U<R!P:' @<V-R
M:7!T<RX\+VQA8F5L/@T*0$ @+3(R,2PT("LR,C(L-"! 0 T*( D)"3QL86)E
M;"!I;F1E>#TB=&]O;&)A<DET96US+G-E87)C:"(^4V5A<F-H/"]L86)E;#X-
M"B )"3PO;&%N9W5A9V5+97D^#0H@"3PO9&%T83X-"BT\+U0S;&]C86QL86YG
M/@T**SPO5#-L;V-A;&QA;F<^#0I<($YO(&YE=VQI;F4 at 870@96YD(&]F(&9I
";&4`
`
end