[TYPO3-core] RFC #9094: Make simulate static a system extension

Martin Kutschker masi-no at spam-typo3.org
Tue Aug 5 13:00:16 CEST 2008


Benjamin Mack schrieb:
> Hey all,
> 
> this is a SVN patch request.
> 
> Branches: trunk only
> 
> Type: Feature / cleanup
> 
> BT reference: http://bugs.typo3.org/view.php?id=9094
> 
> Problem: The simulate static feature is not used all the time and
> therefore shouldn't be in the core itself. This way we can keep our core
> classes smaller and have optional features as - yeah - optional packages.
> 
> Solution: Therefore I created an extension "simulatestatic".
> 
> * I extracted all the necessary parts and also added a new hook in
> class.tslib_fe.php. In all the other cases I made use of existing
> functionalities and hooks.

Odd, that you need a new hook for config processing. Real URL doesn't
need it.

One note to the hook: in tslib_fe you state that config processing is
the point. Yet you pass only the parent object to the params array,
which issn't necessary as it's passed along as second parameter anyway.
I suggest you pass a reference to the conf array of the parent instead
of the parent.

> * I rewrote some configuration options to have a better structure
> (config.simulateStaticDocuments.paramEncoding instead of
> config.simulateStaticDocuments_pEnc etc) the old ones are still usable
> of course until TYPO3 4.5.

No, this has to go. Config does not allow subkeys as it will be merged
with page.config (but not recursively).

And please don't use "private", make it "proteced", so our XCLASS happy
users stay happy.

Masi


More information about the TYPO3-team-core mailing list