[TYPO3-core] RFC: #8014: remove empty tabs from TCEForms

[Malte Jansen]

Hi Oli,

Oliver Hader schrieb:
> Hi Malte,
> 
> Malte Jansen schrieb:
>> In Rev. 3449. (Bug #7634)
>>
>> Following should make the bug:
>>
>> return $GLOBALS['TBE_TEMPLATE']->getDynTabMenu($parts, $idString, 0, 
>> false, 50, 1, false, 1, $GLOBALS[$table]['ctrl']['dividers2tabs']);
>>
>> To me it's new that the $GLOBALS stores the TCA in the way from above.
> 
> Correct, that was my fault some weeks ago. Please just add the obviously 
> missing "['TCA']"...
> 
>> By the way, there might be an other problem in this patch for the 
>> backwards-compability:
>> OLD: function getDynTabMenu($parts, $idString) {
>> NEW: function getDynTabMenu($parts, $idString, $table) {
>>
>> Perhaps it might be better to use it the following way:
>> function getDynTabMenu($parts, $idString, $dividers2tabs = 1) {
> 
> To be "full" backward compatible, the t3lib_TCEforms method could be:
> function getDynTabMenu($parts, $idString, $table='') { ...
> And if no $table is set, it uses the old two-arguments-call.
IMO it's seem to me better to use
function getDynTabMenu($parts, $idString, $dividers2tabs = 1)
because the table has nothing to do with this function, it's just the 
generatator for the dynTabMenu, so only information needed is the 
div2tabs- part...

Cheers,

Malte