[TYPO3-core] RFC: Feature #4064 - Navigation title in tree view

Thomas Hempel thomas at typo3-unleashed.de
Wed Sep 5 08:39:06 CEST 2007


Hi,

>> (strlen(trim($row['title'])) == 0)
>>
>> I prefer this:
>>
>> $var === ''
>>
>> but as trim returns a string trim($row['title'])=='' would be save.
>>
>> Elsewhere we have this:
>>
>> strcmp($var,'')
> 
> 
> I have stumbled over the same question in my previous patch! I usually
> dislike strcmp because it is very unintuitive when reading. The "==="
> comparison is more my style and much easier to read. Is it slower? More
> error prone? If not, I would stick to that.

Fine with me. I'll change that to

(trim($row['title']) == '')

before commit if I get the second +1. ;-)


Greets,
Thomas



-- 
typo3-unleashed.net


More information about the TYPO3-team-core mailing list