[TYPO3-core] TCAmain and $LANG

Dmitry Dulepov 9f4eetb02 at sneakemail.com
Thu May 3 11:07:23 CEST 2007


Martin Kutschker wrote:
> In t3lib_tcemain there are currently two occurences of $LANG.
> 
> prependLabel() uses it if present, but has a *hm* out-dated fallback.
> 
> checkValue_flex() uses it directly without a fallback.
> 
> But the comments on top say this:
> 
>  * Dependencies:
>  * - $GLOBALS['LANG'] (languageobject) may be preferred, but not fatal.
> 
> Bug #5550 shows that we need another refernece to $LANG (well to 
> t3lib_cs, but $LANG has one).
> 
> What do you think how we should resolve this? Shall we simply make 
> TCAmain depend on $LANG or shall checkValue_flex() get a fallback to 
> iso-8859-1?

I expect that tcemain is called from BE scripts that include $LANG by 
default. The only thing when $LANG is not there, it may be CLI scripts.

But I think we should require $LANG in TCEmain. I even had an idea to 
move many hard-coded links from TCEmain to separate language file. It is 
a bit strange and disappointing for users to see errors in English 
because often they cannot understand it and work with different language 
by default. But it comes to changing logging system, etc. Big change...

Still I think we need $LANG there.

-- 
Dmitry Dulepov

Web: http://typo3bloke.net/
Skype: callto:liels_bugs

"It is our choices, that show what we truly are,
far more than our abilities." (A.P.W.B.D.)


More information about the TYPO3-team-core mailing list