[TYPO3-core] RFC: Bug 5718: IRRE - Copying a page with related child records leads to duplicates of each children

[Franz Holzinger]

Hello Oliver, 

>> I think this if to avoid duplicate copies should be moved inside of the
>> first if of the copyRecord function:
>> In no circumstances a duplicate copy of the same will be needed. Or the
>> contents of $this->copyMappingArray would be wrong.
> 
> I though about the same on writing the patch. But I also though that
> some day it could be required to have kind of "drafts" for IRRE children
> and thus copying child records more than once (e.g. done by any hook).

Yes, but I think it is more understandable to have all things, which belong 
together, done inside of the same function. You could add an additional 
special parameter in the future. 

> But I'm fine with moving the check against $this->copyMappingArray to
> the function copyRecord(). I noticed that I forgot to do this also for
> the raw copying in the function copyRecord_raw().

fine. 

 - Franz