[TYPO3-core] RFC: feature #2743

[Ingmar Schlecht]

Hi Wolfgang,

Wolfgang Klinger wrote:
> -			if (!is_array($val))	{

Here's an is_array() check...

> +	function substituteConstantsCallBack($matches) {
> +		return isset($this->flatSetup[$matches[1]]) ? $this->flatSetup[$matches[1]] : $matches[0];
> +	}

...but in your function there isn't. Will it have any consequences?

IMHO it needs to be changed to
> +		return isset($this->flatSetup[$matches[1]]) && !is_array($this->flatSetup[$matches[1]]) ? $this->flatSetup[$matches[1]] : $matches[0];

One question before I give a +1: How is the speed improvement in numbers?

cheers,
Ingmar