[TYPO3-core] RFC: fix bug #3600 - config.formMailCharset

Franz Holzinger franz at fholzinger.com
Fri Jun 30 18:10:18 CEST 2006


Martin Kutschker a écrit :

>
> Part 1:
> Now that the t3lib_htmlmail charset fix is in it is possible to set
> the charset of the mail. This is done by calling the parent's start()
> and then checking for config.formMailCharset.
>
> Part 2:
> To make the setting really work it is necessary to convert the charset
> from the form into the desired mail charset. The patch does this. Note
> that renderCharset is used because TYPO3 (see index_ts) does
> automatically convert the sent data (metaCharset) into the internal
> charset (renderCharset).
>

> $this->organisation = $convCharset ?
> $GLOBALS['TSFE']->csConvObj->conv($val,$GLOBALS['TSFE']->renderCharset,$this->charset)
> : $val;

You have identical code 4 times here and they are rather long lines.
Please make a function out of it.


- Franz






More information about the TYPO3-team-core mailing list