[TYPO3-core] RFC: incorrect image url for thumbnails

Dmitry Dulepov dima at spamcop.net
Tue Feb 21 20:48:11 CET 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello!

This is a CVS patch request.

Type: bug

Branch: TYPO3_4-0

Description: t3lib_BEfunc may create wrong image path for thumbnail when
image is smaller or equals in size to thumbnail.

Solution: Use the same path building logic as a couple of lines below
for larger images.

FAQ:
Q: How did you find it?
A: TemplaVoila does not show images properly.
Q: Why cannot it solved in TemplaVoila than?
A: Because TemplaVoila passes parameters correctly but
t3lib_BEfunc::thumbCode did not use them correctly in one specific case.
It does not distinguish between absolute and relative part in the
patched part of code (but does it in others parts). Existing code has
hardcoded '..' which made path look properly for old page module. With
proposed patch all modules will work properly.

Dmitry.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFD+257RVcYnKJ8N6kRAgYyAJ9/6UfY+8QQEOCSEfzL0wNfzzw+xgCfWtmu
G9k+KalT7/pOnyRupvJg7zE=
=SvWn
-----END PGP SIGNATURE-----
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: thumbnail.txt
Url: http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20060221/e75fecf7/attachment.txt 


More information about the TYPO3-team-core mailing list