[TYPO3-core] RFC: classes for List module ignore BACK_PATH

Dmitry Dulepov dmitry at typo3.org
Thu Dec 21 09:12:11 CET 2006


Hi!

Committed to both. Many thanks for fast review!

Dmitry Dulepov wrote:
> This is SVN patch request.
> 
> Branches: both
> 
> Problem: several classes for List module violate our own practices and 
> ignore BACK_PATH for URLs. These classes (not module itself but some of 
> its helper classes!) assume they run from typo3/. Interestingly they do 
> not assume so for images and correctly use BACK_PATH for images 
> (otherwise skinning will not work). This inconsistence causes problems 
> if one tries to reuse those classes from extensions: extension author 
> have to create a subclass and copy several functions to his own 
> extensions only to fix this problem.
> 
> Solution: add $this->backPath (in one place it is $this->doc->backPath) 
> where necessary.
> 
> List module works ok after such change.
> 
> I really home it comes to both branches (bug fix!) and comes fast 
> (pretty obvious fix). Currently TemplaVoila needs this thing ASAP and I 
> really hate to copy half of List module functions to TemplaVoila just to 
> fix this bug...


-- 
Dmitry Dulepov

Web: http://typo3bloke.net/
Skype: callto:liels_bugs

"It is our choices, that show what we truly are,
far more than our abilities." (A.P.W.B.D.)


More information about the TYPO3-team-core mailing list