[TYPO3-core] RFC: incorrect clearCache menu can be generated for non-admin user

[Dmitry Dulepov]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello!

This is a CVS patch request.

Type: bug

See: http://bugs.typo3.org/view.php?id=3218 and
http://bugs.typo3.org/view.php?id=3226

Branch: HEAD & TYPO3_4-0

Description: function template::clearCacheCmd() accepts two parameters:
page id ($id) and a flag to add save options ($addSaveOptions -- bad mix
of functionality in my opinion!). Everywhere except templavoila this
function is called with $addSaveOptions=true. This causes correct save
and clear cache menu to be generated. However if function is called with
$addSaveOptions=false and $id != 0 and current user is not admin,
function does not produce anything, though it must produce code to clear
cache for the current page.

Solution: correct one "if" in the function (see attached patch).

This bug affects templavoila, patch is verified in my test environment.

Dmitry.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEOqYyRVcYnKJ8N6kRAmI9AJ9sdQ5MYxOZfnCkB4/fgATxKxvyngCgxZX6
H+P3mQh6ikHsvuC9vyQEUbo=
=iIBY
-----END PGP SIGNATURE-----
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: clear_cache_this_page.txt
Url: http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20060410/895267d2/attachment.txt