[TYPO3-v4] Patch-for-a-patch, nitpicking and negative votes

Philipp Gampe typo3.lists at philippgampe.info
Sun Mar 27 15:27:23 CEST 2011


Hi Jigal,

Jigal van Hemert wrote:
 
> With reviewing code in Gerrit I see a tendency to just throw -1 votes if
> there are tiny "problems" in the change. E.g. a comment which is
> slightly wrong, bugtracker number misspelled, variable name not clear,

Doesn't Gerrit clear those votes after pushing a new patch set?
Then this would be ok for me, because you should vote again on the clean 
patch.

Best regards
-- 
Philipp Gampe


More information about the TYPO3-project-v4 mailing list