[TYPO3-mvc] A lot of failing unit tests for Extbase and Fluid

Bastian Waidelich bastian at typo3.org
Wed Jun 27 15:24:28 CEST 2012


Tobias Liebig wrote:

Hi Tobi,

>> I could fix the test [...]
>> in Tx_Extbase_MVC_Controller_ActionController::processRequest()
>> Can someone of you confirm and create a patch if it makes sense to you?

> You're right. This actually works around the problem but does not fix the issue.

The issue being a PageRenderer that doesn't function with USER_INT.

> I like to suggest to move the request member with its setter/getter into the
> super class from Tx_Extbase_MVC_Web_Response to Tx_Extbase_MVC_Response to have
> the same API for all Response implementations instead of checking for a certain
> Class in the action controller.

I don't agree to be honest. Having a relation to the request in the 
response is too much dependency IMO. That's why I'd vote for fixing the 
PageRenderer and remove the setter from Web_Response afterwards.

Best

-- 
Bastian Waidelich
TYPO3 Core Team Member

TYPO3 .... inspiring people to share!
Get involved: typo3.org




More information about the TYPO3-project-typo3v4mvc mailing list