[Typo3-shop] Bugs in 2.2.9?

[Eirik Wulff]

Hi,

I think I may have found a bug in the current version of tt_products...

At first after updating, there was some confusion with using my payment 
handlerScript. It couldn't get the getOrder and finalizeOrder functions 
(because they now reside in the class tx_ttproducts_basket_div). That 
was when I discovered that the order was finalized ANYWAY. Without 
payment clearance.

This is due to the code around line 412 in 
lib/class.tx_ttproducts_basket_div.php, the if checking for $handleScript:

if (trim($this->conf['paymentActivity'])=='finalize' && $handleScript)
{...}

is closed without an else for what to do if there is no $handleScript 
(which, of course, is to finalize the order). Hence, the order is 
finalized even though the handleScript does not clear the payment.

I fixed this for my part by enclosing the rest of the code following the 
'if' in an else, seems like that did the trick. Although I can't test it 
right now due to a payment gateway failure, my orders are no longer 
finalized when failing...

Of course, this could be due to a change in the handleScript API, but I 
couldn't see anything about this anywhere...? I did the necessary 
changes in the handleScript now, replacing $this->getBasket with 
tx_ttproducts_basket_div::getBasket and so on, so now I hope this will 
work...

Luckily, this solution is not live yet... ;)


Regards,

E. Wulff