[TYPO3-project-formidable] Bug in i18n lister search ? and other

[Jerome Schneider]

Hello Francois,

Yes u're right I forgot to handle the case of a compiled LISTER view in 
i18n functions.

I'm going to patch this sooooon. :)


Jerome


François SCHOSSIG a écrit :
> Hello,
> 
> Thanks for the great i18n integration. Two points...
> 
> ***** 1 *****
> I get a Mayday error loading a page:
>      SQL QUERY IS NOT VALID
>      Column 'sys_language_uid' in where clause is ambiguous
>      SELECT SQL_CALC_FOUND_ROWS
> 
> -> in the file 
> ameos_formidable/api/base/dh_lister/api/class.tx_dhlister.php on line 
> 807, you have:
>      if($this->i18n()) {
>           $aQuery["WHERE"] .= " AND sys_language_uid='" . 
> $this->i18n_getSysLanguageUid() . "' ";
>      }
> It seams the place where the problem is.
> 
> By putting the next code, the error disappears.
>      if($this->i18n()) {
>           $aQuery["WHERE"] .= " AND plain.sys_language_uid IN (-1,0) ";
>      }
> 
> But, I do not know it it should be plain.sys_language_uid or 
> compiled.sys_language_uid there ?
> 
> ***** 2 *****
> On another side, you search with:
>      AND sys_language_uid='" . $this->i18n_getSysLanguageUid()
> This is right in the case of another language than the default language. 
> But in the case of the default language, the search should be:
>      AND plain.sys_language_uid IN (-1,0)
> Explanation:
>   sys_language_uid = 0 means that the record is in the default language,
>   sys_language_uid = -1 means that the record is the same for all 
> languages (not to be translated)...
> 
> Regards...
> -- 
> F. SCHOSSIG, ICT Manager
> Assemblée des Régions d'Europe
> http://www.a-e-r.org
> 
>