[TYPO3-dam] cc_metamp3: mp3 Index

[René Fritz]

Hi Thomas

> http://www.thomas-peterson.de/fileadmin/ext/cc_metamp3/T3X_cc_metamp3-0_2_0
>-z-200601012150.zip
>
> @Rene Fritz can you look at the code? Is Correct or can i make it better?

Thanks for the extension. I had it look at it. Here are my comments:

- TCA labels missing ":"
- Laenge instead of Länge
- The artist is the creator not the publisher
- parseDate() is not used
- the locallang*.php files can be deleted
- the manual is from cc_metaexif

As you see very small things and in general it's ok and it works. Fine.


I have two comments which are more general.

Extensions prefixed with "cc_" are known to be published by me. Of course this 
prefix is not reserved but you might want to use yours or just none what is 
ok.


Another thing is the extensions of the tx_dam table which is fine as you did 
it, but I suggested earlier that such commonly wanted and used extensions of 
the table might be published by me.

Why? Two reasons:

- I would extend the table with "album" not "tx_metamp3_album" which is just 
nicer. This is of course not allowed for extension because of name conflicts 
but as I'm the "owner" of tx_dam I can extend it in any way without conflict.

- That table extensions should be commonly used and we should agree on one 
extension to prevent having five different mp3 extensions.

I suggest that the table extension should be published by me, but the 
mp3/whatever indexing services should be published by others.


Thomas Murphy made already suggestions in this direction and it would be nice 
to agree here on a commonly used table extension which is usable for all 
audio data not only for mp3.

What I suggest is to place the fields like Album on the main tab below Title 
and the technical data like Bitrate on the Metrics tab like images have.
I don't know if any other fields are needed for audio files?


René


-- 
COLORCUBE
digital media lab

www.colorcube.de