[TYPO3-commerce] Request for help: Clean up commerce

[Torben Hansen - Skyfillers]

Hi Ingo,

I did´nt mean "basket_item" but "commerce_item". I could´nt find a class, which extens "tx_commerce_item" and if you look into the class, it´s just empty with no properties/functions. The comments of the class mentions, that this class should be extended by "basket_item", but "tx_commerce_basket_item" is just a normal class not extending " tx_commerce_item" or anything else. I´ve also searched the whole extension for any references to that class and could´nt find any.

Are you sure this class is still in use?

Best regards
Torben


> -----Ursprüngliche Nachricht-----
> Von: typo3-project-commerce-bounces at lists.typo3.org [mailto:typo3-project-
> commerce-bounces at lists.typo3.org] Im Auftrag von Ingo Schmitt
> Gesendet: Montag, 16. Mai 2011 07:15
> An: TYPO3 commerce extension project
> Betreff: Re: [TYPO3-commerce] Request for help: Clean up commerce
> 
> Hi Torben,
> 
> basket_item is used by the basket class. The item stores each "line" of the
> basket.
> 
> Regards
> 
> Ingo
> 
> > Hi Cristian,
> >
> > I did have a look at both of your patches and they look good to me. I did not
> work with fluid before, but after looking at your code I´m pretty sure I´ll do that
> in the future.
> >
> > As soon as I´m accepted as team member, I will commit my first changes for
> the lib/ directory to trunk. Btw. - what´s with
> "lib/class.tx_commerce_item.php"? I can´t find any reference to that class so I
> think, it´s an old one which can be deleted.
> >
> > Best regards,
> > Torben
> >
> >
> >> -----Ursprüngliche Nachricht-----
> >> Von: typo3-project-commerce-bounces at lists.typo3.org
> >> [mailto:typo3-project- commerce-bounces at lists.typo3.org] Im Auftrag
> >> von Christian Kuhn
> >> Gesendet: Sonntag, 15. Mai 2011 18:51
> >> An: TYPO3 commerce extension project
> >> Betreff: Re: [TYPO3-commerce] Request for help: Clean up commerce
> >>
> >> Hey.
> >>
> >> On 05/13/2011 01:44 AM, Christian Kuhn wrote:
> >>> 'Move to fluid' patch, now. You are invited to review!
> >>
> >> Ok, there are now two pending patches: #26795 moves pi2 (basket) to
> >> fluid,
> >> #26827 moves pi6 (invoice) to fluid. Reviews are very much appreciated!
> >>
> >> Plan for the next patches: I'd like to finish the move to fluid with
> >> the other pi's (I've already started the battle with pi4, but the
> >> remaining pi's are more complicated than pi2 and pi6). I've already
> >> dropped the idea to be completely backwards compatible, I see no
> >> other solution than breaking changes. The point is, that we end up with a
> solid code base this way ...
> >>
> >> While creating the fluid patches I realized that the model / object
> >> layer is not really ideal, too (well, there exists one, which is
> >> already a big plus for commerce). Thus, after fluid, I'll start to
> >> work on this level. It would help a lot if we have a cleaned lib/ directory at
> this point!
> >>
> >> Regards
> >> Christian
> >> _______________________________________________
> >> TYPO3-project-commerce mailing list
> >> TYPO3-project-commerce at lists.typo3.org
> >> http://lists.typo3.org/cgi-bin/mailman/listinfo/typo3-project-commerc
> >> e
> > _______________________________________________
> > TYPO3-project-commerce mailing list
> > TYPO3-project-commerce at lists.typo3.org
> > http://lists.typo3.org/cgi-bin/mailman/listinfo/typo3-project-commerce
> >
> >
> 
> 
> Mit freundlichen Gruessen
> Ingo Schmitt
> 
> *** BITTE BEACHTEN SIE UNSERE NEUE ANSCHRIFT! ***
> 
> --
> Marketing Factory Consulting GmbH  *   mailto:is at marketing-factory.de
> Marienstrasse 14                   *          Tel.: +49 211-361176-63
> D-40212 Duesseldorf, Germany       *          Fax:  +49 211-361176-99
> Amtsgericht Duesseldorf HRB 53971  * http://www.marketing-factory.de/
> 
> Geschaeftsfuehrer:    Peter Faisst   |   Katja Faisst
> Karoline Steinfatt   |   Christoph Allefeld   |   Markus M. Kimmel
> 
> _______________________________________________
> TYPO3-project-commerce mailing list
> TYPO3-project-commerce at lists.typo3.org
> http://lists.typo3.org/cgi-bin/mailman/listinfo/typo3-project-commerce