[TYPO3-commerce] Looking for bugfix for Bug #1719 of com_advanced_products
Sven Schumacher
sschu at computerteam.de
Thu Sep 30 11:02:11 CEST 2010
Hello Sascha,
doesn't work, sorry. Crashes fast (so the endless loop seems to be fixed
by that, but another error occurs).
And regarding Mortens advice: I just tried your idea, but
CalculateDeliveryCosts or the trimExplode of the images, seem still to
crash. And that part can't be excluded in that simple way without
touching class.tx_commerce_article.php, too.
I'm not experienced with the XCLASSing of typo3-classes, but perhaps it
would be possible to extend tx_commerce_article by adding that
load_dataP as a method of the extended class.
The get_tax method as to be modified, too, to get the tax-value out of
the product, if the article has set no tax. So another reason to extend
the class.
So like I said, after the shop is running, I will try to modify
com_advanced_products to use a class extending tx_commerce_article and
add patches for commerce_ext, where it seems to be necessary.
For the work on com_advanced_products I will use the attached
com_advanced_product.tar.gz of Sascha, if he agrees.
Thanks for your ideas and work
Sven
Am 30.09.2010 09:27, schrieb Sascha Egerer:
> Hi!
>
> Can you please try this Version? If it works, i will create a clean
> patch at t3con and update the extension.
>
> In one of my shops this extnension works.
>
> Regards
>
> Sascha Egerer
>
> Am 30.09.10 08:24, schrieb Morten Haggren:
>> Hi Sven,
>>
>> just set $articleData->prices_loaded=true;
>> before calling load_data and back to false after - that way you dont
>> have to rewrite patch class.tx_commerce_article.php every new commerce
>> release.
>>
>> /Morten Olesen
>>
>> On 2010-09-30 00:47, Sven Schumacher wrote:
>>> Hello,
>>>
>>> com_advanced_products uses the hook postpricenet/postpricegross and it
>>> crashes when it calls:
>>>
>>> $articleData = t3lib_div::makeInstance('tx_commerce_article');
>>> $articleData->init($articleUid['uid_article']);
>>> //up to here everything is fine
>>> $articleData->load_data(); // <<-- this is the bad one.
>>>
>>> So load_data ends in an endless loop because of calling load_prices.
>>> I added to the original class.tx_commerce_article.php another load_dataP
>>> which is the same function without load_prices-Call.
>>
>>
>>
>>
>
More information about the TYPO3-project-commerce
mailing list