[TYPO3-commerce] order confirmation says user email is invalid anyway

[Ingo Schmitt]

Hi Michiel,
> Thibaut van de Mortel wrote:
>> Hello list,
>> when I reach checkout's last step, the confirmation message says that 
>> the user email is invalid even if it is valid.
>>
>> I think this problem comes from lines 957-958 in 
>> class.tx_commerce_pi3.php :
>>
>> $this->userMailOK = $this->sendUserMail($orderId,$orderData);
>> $this->adminMailOK = $this->sendAdminMail($orderId,$orderData);
>>
>> The problem is that those variables are always equal to NULL because 
>> both functions (sendUserMail and sendAdminMail) do this :
>>
>> return t3lib_div::plainMailEncoded([...]) ;
>>
>> But this function doesn't return anything (even if email was sent), 
>> that's why both variables are always empty.
>>
>> I don't know the technique to be sure that an email has been sent, but 
>> it looks like both variables are meant to say precisely that. They 
>> just don't get the expected answer from "plainMailEncoded" as it 
>> doesn't return anything at all.
>>
>> I don't know the solution for this problem. We cannot change t3lib_div 
>> because it is a core file.
>>
>> The easy solution is to assume that the email has been correctly sent 
>> as long as the email address looks valid ; but it is surely not the 
>> cleanest way to do it.
>>
>> Anyway, it looks like a bug to me, shall I do an official bug report 
>> about it?
> 
> Dear Thibaut,
> 
> It was reported long long ago . . . and the fix is really simple . . . I 
> don't know what is wrong with the team that is maintaining commerce . . .
> 
> 
> http://bugs.typo3.org/view.php?id=6314
> 

I did fix this in commerce in PI3. Pi5 ist not for use, it's an old copy 
of pi3.

ingo

> Kind regards,
> 
> 
> Michiel Roos
> 


Mit freundlichen Gruessen
-- 
Ingo Schmitt                        mailto:is at marketing-factory.de
Marketing Factory Consulting GmbH   http://typo3.marketing-factory.de/
Content Management mit Typo3: Beratung - Schulung - Realisierung