[TYPO3-commerce] checkout email error message

[Andre Dittmar]

Hello,

I've already used the provided patch, but oddly enough I've still have  
the problem? I always get all the messages at once after a sending a  
order. The whole process seems to work, Customer and Shopadmin also  
receives their mails.

I'm using the unchanged class.tx_commerce_pi3.php of the current  
offical version 0.9.2.
I've taken a look in the pi3 and now I'm a bit confused about the  
code? :-)

The calls of the two methods for sending the mails:

794: $this->sendUserMail($orderId,$orderData);
795: $this->sendAdminMail($orderId,$orderData);
....

Then the setting of the marker:

815: $markerArray['###FINISH_MESSAGE_GOOD###'] = $this- 
 >pi_getLL('finish_message_good');
816: $markerArray['###FINISH_MESSAGE_BAD###'] = $this- 
 >pi_getLL('finish_message_bad');
817: $markerArray['###FINISH_MESSAGE_EMAIL###'] = $this- 
 >pi_getLL('finish_message_email');
818: $markerArray['###FINISH_MESSAGE_NOEMAIL###'] = $this- 
 >pi_getLL('finish_message_noemail');
819: $markerArray['###FINISH_MESSAGE_THANKYOU###'] = $this- 
 >pi_getLL('finish_message_thankyou');


As far as I can see, those markers will always be set with the  
messages, regardless what happening inside the sendUserMail() and  
sendAdminMail()?

Shouldn't be there some conditionals like e.g.:

$markerArray['###FINISH_MESSAGE_EMAIL###'] = '';
$markerArray['###FINISH_MESSAGE_NOEMAIL###'] = '';

if(this->sendUserMail($orderId,$orderData)) {
	$markerArray['###FINISH_MESSAGE_EMAIL###'] = $this- 
 >pi_getLL('finish_message_email');
} else {
	$markerArray['###FINISH_MESSAGE_NOEMAIL###'] = $this- 
 >pi_getLL('finish_message_noemail');
}

to control the output of the template?


I'm still confused why this seems to work at other installations? Does  
anyone know what I might still doing wrong?

Many Thanks,
Andre